Skip to content

feat(release): v0.7.0 release foundation — version stamping, secret guard, release pipeline - #103

Open
senolcolak wants to merge 12 commits into
mainfrom
feat/v0.7.0-release-foundation
Open

senolcolak wants to merge 12 commits into
mainfrom
feat/v0.7.0-release-foundation

Conversation

@senolcolak

Copy link
Copy Markdown
Collaborator

Reopened from feat/v0.7.0-release-foundation (supersedes #102 — the new require-one-approval ruleset matches refs/heads/release/* and blocks direct pushes to the old branch name; identical content plus the review-round-1 fixes).

Implements the top action items from the comprehensive review (docs/review/comprehensive-review-report-2026-10-12.md). Companion to the docs PR #101.

R1 — Version stamping (was CRITICAL)

The Makefile has always passed -ldflags "-X main.Version=...", but no var Version existed — Go silently ignores -X for undefined symbols, so every shipped binary was unidentifiable.

  • var Version = "dev" in cmd/lightstack/main.go, lightstack --version flag, startup log line
  • Dockerfile passes its VERSION build-arg into the binary — declared in the builder stage (an ARG in the runtime stage is out of scope for the build RUN and expands to empty)
  • Verified locally: make build → --version round-trips the git-describe stamp; explicit -X main.Version=v0.7.0-test round-trips exactly; CGO_ENABLED=0 GOOS=linux GOARCH=arm64 builds (what the release workflow does — Ceph RBD sits behind the ceph build tag)

S2 — Refuse well-known/empty JWT secrets (was HIGH)

config/lightstack.yaml and .env.example ship public default secrets; tokens are stateless, so knowing the secret = minting admin tokens. The old code only warned, and only on one of the two literals.

  • LoadConfig now refuses both shipped literals and the empty secret, with an actionable error message
  • LIGHTSTACK_ALLOW_INSECURE_DEFAULT_SECRET=1 is the documented escape hatch for isolated dev/test
  • Both docker-compose dev stacks and make run opt in explicitly (commented); the Horizon stack and Helm chart already require a real secret; deploy scripts already generate random secrets
  • lightstack-migrate is exempt (LoadConfigForMigration): it never signs or validates a token, and the image entrypoint and the documented Kubernetes init container run it against the canned config before any secret is wired in
  • Tests pin the refusal for all three values, the escape hatch, the migration exemption, and a positive control

R3 — Release pipeline (.github/workflows/release.yml)

Push a v* tag → test gate → linux/amd64+arm64 binaries + checksums → --version round-trip guard (R1 regression protection) → multi-arch image to ghcr.io → draft GitHub Release → Helm chart published as OCI artifact. Image tag and chart appVersion carry the bare version (0.7.0) to match the in-repo chart's appVersion/image.tag default; the binary reports the full v0.7.0.

R2 — Chart alignment

Chart.yaml 0.3.0 → 0.4.0 (annotated history); appVersion: 0.7.0 — becomes true when v0.7.0 is tagged.

Also

Review status

Round 1 findings (1 Critical, 2 High, 1 Medium, 4 Low) all fixed in the second commit — see its message for the item-by-item mapping.

Testing

  • make test — PASS (full unit suite, race detector), after every fix round
  • helm template with required values — renders clean (helm lint fails on empty image.repository by design, FR-018, pre-existing)
  • Build/version round-trips verified on amd64 + arm64

After merge

Tag v0.7.0 → the pipeline produces the release; recommend also deleting the stale v1.0.0 tag (451+ commits behind, misleading latest).

Not in scope (tracked in the review report)

S1 token revocation, S4 rate limiting, C1/C2 shutdown races — follow-up PRs.

Uwe Schwaeke added 5 commits October 12, 2026 18:56
…uard, release pipeline

Implements the top action items from
docs/review/comprehensive-review-report-2026-10-12.md:

R1 — version stamping (was: CRITICAL, every shipped binary unidentifiable):
- main.Version var + lightstack --version flag + startup log
- Dockerfile passes the VERSION build-arg into the binary via ldflags
- the Makefile's existing -X main.Version injection now actually works
- verified: make build -> --version round-trips the git-describe stamp;
  explicit -X stamps round-trip exactly; linux/arm64 cross-builds CGO-free

S2 — refuse well-known/empty JWT secrets (was: HIGH, forged-admin takeover):
- LoadConfig refuses the two literals shipped in config/lightstack.yaml
  and .env.example, and the empty secret, with an actionable error
- LIGHTSTACK_ALLOW_INSECURE_DEFAULT_SECRET=1 is the documented escape
  hatch for isolated dev/test stacks
- the stub-mode dev compose stack and 'make run' opt in explicitly with
  comments; the Horizon stack and Helm chart already require a real secret
- unit tests: refusal pinned for all three values, escape hatch pinned,
  positive control for a random secret

R3 — release pipeline (.github/workflows/release.yml):
- tag-triggered (v*): test gate -> linux/amd64+arm64 binaries with
  checksums -> --version round-trip check -> multi-arch image to ghcr.io
  -> draft GitHub Release -> Helm chart published as OCI artifact with
  appVersion pinned to the tag

R2 — chart version 0.3.0 -> 0.4.0 (annotated); appVersion 0.7.0 target

Also: Horizon OPENSTACK_KEYSTONE_DEFAULT_ROLE _member_ -> member (matches
the seeded admin/member/reader roles; _member_ matched nothing).

make test: PASS (all unit tests, race detector)

Signed-off-by: Uwe Schwaeke <uwe.schwaeke@sap.com>
C1 (CRITICAL): release.yml migrate build passed -s -w as top-level go
build flags — 'flag provided but not defined: -s' — and bash -e killed
the loop on the first iteration, so the pipeline could never produce
anything. Now -ldflags "-s -w" like the lightstack line.

H1: Dockerfile declared ARG VERSION only in the runtime stage, so the
builder stage's ${VERSION} expanded to empty and the image would carry
an unidentifiable binary — the exact failure class R1 exists to remove.
ARG VERSION=dev is now declared in the builder stage (annotated).

H2: the JWT-secret guard gated lightstack-migrate, breaking shipped
deployment paths that run it against the canned config before any secret
is wired in (image entrypoint CMD, the documented Kubernetes init
container, test/migration_test.sh). LoadConfig now delegates to a shared
loadConfig(path, enforceSecretGuard); the new
common.LoadConfigForMigration skips the guard — the tool never signs or
validates a token (it reads database.url and logging only). Pinned by
TestLoadConfigForMigrationSkipsSecretGuard.

M1: image was pushed as :v0.7.0 while the in-repo chart's appVersion
(0.7.0, no v) is what image.tag defaults to — a repo-direct helm install
would ImagePullBackOff forever. The workflow now computes
IMAGE_TAG=${GITHUB_REF_NAME#v} for the image tag and the chart's
--app-version; the binary keeps the full v-prefixed tag (consistent with
git describe stamps).

L1: deployments/docker/docker-compose.yaml also uses the default secret
without the escape hatch — added (with the same dev-only warning
comment).

L2: docs/review/comprehensive-review-report-2026-10-12.md was referenced
from the new code/comments but only existed on the docs branch — landed
in-tree (identical content on both branches; merges cleanly with
PR #101).

L3: release.yml action versions aligned with ci.yml (checkout@v6,
setup-go@v6).

L4: GitHub Release file glob narrowed to
dist/lightstack-<tag>-*-* + dist/checksums-* so the chart tarball can
never be absorbed by step reordering.

make test: PASS (all unit tests, race detector)

Signed-off-by: Uwe Schwaeke <uwe.schwaeke@sap.com>
F1 (HIGH, merge-blocker): the Horizon chart's bundled copy of
local_settings (charts/horizon/files/) was left with _member_ — only the
compose-path source was fixed. That both breaks 'make chart-test' (the
horizon-chart-check step re-renders and diffs the bundled copy, so the
helm-check CI job fails) and leaves the Helm/Kubernetes Horizon path
unfixed entirely: the chart's ConfigMap mounts files/local_settings
verbatim. Synced via 'make horizon-chart-sync' (the sync seds don't
touch the role line; the only diff is _member_ -> member) and verified
'make chart-test' passes end to end (both charts lint+render+unittest,
horizon files in sync).

F2 (MEDIUM): the GitHub Release files glob
dist/lightstack-<tag>-*-* does not match the lightstack-migrate-<tag>-*
binaries — they were built and checksummed but never attached, and the
checksums file would reference assets absent from the release. Added the
migrate pattern.

F3 (LOW): a bare 'docker run' of the image now requires
LIGHTSTACK_JWT_SECRET (the server refuses the canned config's default —
fail-closed by design). Documented above the Dockerfile CMD and in the
CHANGELOG; lightstack-migrate in the entrypoint is exempt (never signs
or validates a token).

Verified: make chart-test PASS (helm 3.19 + helm-unittest), release.yml
valid YAML; Go unit tests unaffected by this round (no Go changes).

Signed-off-by: Uwe Schwaeke <uwe.schwaeke@sap.com>
M-1 (MEDIUM): the release test gate ran 'make test' on a bare runner —
no postgres service, no LIGHTSTACK_TEST_DB_URL, no -race — so every
DB-backed unit test silently t.Skip()-ed, and (ci.yml triggering only on
branches, not tags) the gate was the only test executed on a tag push.
The test job now mirrors ci.yml's unit job: postgres:18.3-alpine service,
LIGHTSTACK_TEST_DB_URL, 'go test -race', timeout-minutes 10.

L-1: the dev compose stacks enabled the escape hatch unconditionally —
even an operator passing a real LIGHTSTACK_JWT_SECRET ran with the guard
off. Now ${LIGHTSTACK_ALLOW_INSECURE_DEFAULT_SECRET:-true}: still ON by
default for dev UX, but settable to false/0 to re-arm the guard.

L-2: dist/ (release workflow output) was in neither .gitignore nor
.dockerignore — host-built binaries were dragged into the docker build
context and at risk of being committed. Added to both.

Hardening from the review's INFO items:
- job-scoped permissions: test gate now contents:read only; the
  publishing job keeps contents+packages write
- concurrency group per tag (cancel-in-progress) so a re-pushed tag
  cannot run two release pipelines in parallel
- timeout-minutes 30 on the release job
- corrected the release-files glob comment (checksums-* is not
  tag-scoped, though it can only match checksum files)

make test: PASS (all unit tests, race detector); all three touched YAML
files parse cleanly.

Signed-off-by: Uwe Schwaeke <uwe.schwaeke@sap.com>
- header: chart appVersion is the bare version (no leading v), matching
  the image tag — the inline comment already said so, the header didn't
- chart publish step: note that the chart lands in the org-level charts
  OCI namespace and relies on GITHUB_TOKEN packages:write covering it

Final review round verdict: CLEAN (no Critical/High/Medium/Low
correctness findings; these were informational notes on comment
wording).

Signed-off-by: Uwe Schwaeke <uwe.schwaeke@sap.com>
@senolcolak

Copy link
Copy Markdown
Collaborator Author

Review-fix loop summary

This PR went through 4 comprehensive review rounds (independent deep reviews of the full diff). Verdicts:

Round Verdict Findings
1 FINDINGS 1 Critical, 2 High, 1 Medium, 4 Low
2 FINDINGS 1 High, 1 Medium, 1 Low
3 FINDINGS 1 Medium, 2 Low (+ hardening notes)
4 CLEAN informational notes only

Round 1 (fixed in b9a0634)

  • C1 — release.yml passed -s -w as top-level go build flags → flag provided but not defined: -s; under bash -e the pipeline died on the first loop iteration and could never produce anything
  • H1 — Dockerfile declared ARG VERSION only in the runtime stage, so the builder's ${VERSION} expanded empty and the image would ship an unidentifiable binary — the exact failure class R1 exists to remove
  • H2 — the JWT guard gated lightstack-migrate, breaking the image entrypoint, the documented K8s init container, and test/migration_test.sh → new LoadConfigForMigration (the tool never signs or validates a token)
  • M1 — image pushed as :v0.7.0 while the chart's image.tag default is 0.7.0 → repo-direct installs would ImagePullBackOff; workflow now strips the v for image tag + chart appVersion
  • L1–L4 — sibling dev compose stack escape hatch; in-tree review report; action-version alignment; release glob narrowing

Round 2 (fixed in 8e53cdd)

  • F1 — charts/horizon/files/local_settings was left stale (_member_ remained): broke make chart-test (helm-check CI) and left the Helm/K8s Horizon path unfixed — synced via make horizon-chart-sync
  • F2 — the GitHub Release glob dropped the two lightstack-migrate binaries (built + checksummed but never attached)
  • F3 — documented that a bare docker run of the image now requires LIGHTSTACK_JWT_SECRET (fail-closed by design)

Round 3 (fixed in e9a43a1)

  • M-1 — the release test gate ran make test on a bare runner: no postgres, no LIGHTSTACK_TEST_DB_URL, no -race — every DB-backed test silently skipped, and it's the only test that runs on a tag push (ci.yml triggers on branches). Now byte-identical to ci.yml's unit job
  • L-1 — dev stacks now use ${LIGHTSTACK_ALLOW_INSECURE_DEFAULT_SECRET:-true} so the guard can be re-armed when a real secret is supplied
  • L-2 — dist/ added to .gitignore + .dockerignore
  • Hardening: job-scoped permissions, per-tag concurrency group, release-job timeout

Round 4 — CLEAN

All fixes verified correct and complete; adversarial sweep found no remaining correctness defects. Two informational comment-wording notes taken in b1492f1.

Verification at each round

make test (full unit suite, race detector) — PASS; make chart-test (both charts lint+render+unittest, horizon sync check) — PASS with helm 3.19; version-stamping round-trips on amd64 + arm64; all touched YAML validated.

Ready for review/merge. After merge: tag v0.7.0 and the pipeline produces the release.

Uwe Schwaeke added 5 commits October 13, 2026 12:56
Comprehensive-review follow-ups on this branch's own diff:

- Secret guard: case-insensitive, whitespace-trimmed matching — the
  uppercase 'CHANGE-ME-IN-PRODUCTION' shipped in README-KVM.md was
  accepted (that example now generates a per-deployment secret, and its
  placeholder string is denylisted too).
- Secret guard: also refuse a well-known/empty keystone.admin_password
  whenever an admin account is configured — admin/secret is public and
  authenticates as the bootstrap admin directly. New
  LIGHTSTACK_ADMIN_PASSWORD env override (mirroring LIGHTSTACK_JWT_SECRET)
  keeps the bare 'docker run' path workable; the Dockerfile CMD comment
  and the docs env-var table now say so.
- CLI subcommands (cleanup, console-tokens) route through the unguarded
  loader like lightstack-migrate: they run on the server's host, whose
  config is only valid because the server's own process carries the
  escape hatch.
- 'lightstack migrate' subcommand: deploy/upgrade scripts have always
  called it; the positional previously fell through to flag parsing and
  started the server instead of migrating. --dry-run prints
  'No migrations to run' — the exact string upgrade-lightstack.sh greps.
- Release workflow: lint, render and unit-test the charts (make
  chart-test — the same gate CI runs on PRs) before 'helm push', which
  cannot be undone.
- Makefile .PHONY covers every target; guard tests are hermetic against
  a developer shell's exported LIGHTSTACK_JWT_SECRET / hatch, and pin
  the new admin-password behavior and the CLI exemption.

Signed-off-by: Uwe Schwaeke <uwe.schwaeke@sap.com>
…ot path

Round 2 of the comprehensive review on this branch:

- F1 (HIGH): the admin-password guard had an omit-both-fields escape,
  but migrations/002 seeds an enabled admin/secret account in EVERY
  deployment and BootstrapAdmin only warns on an empty configured
  password — omitting the field is precisely how the public credential
  stays live. The guard now refuses empty/well-known admin_password
  unconditionally. The deploy scripts (deploy-single-node.sh,
  deploy-turnkey.sh) generate a real admin password (openssl rand) and
  carry it through the rendered config, the CLI env file and the
  summary; README-KVM's example documents both generated secrets (its
  placeholders are denylisted too).
- F2 (HIGH): the CI rgw-integration stack booted the image's canned
  admin/secret with a real JWT secret and no opt-out — the new guard
  crash-looped it (job already red on the previous commit). The stack
  now arms the documented hatch, matching the dev-stack policy.
- F3: docker-compose-horizon.yml requires LIGHTSTACK_ADMIN_PASSWORD
  like it requires the JWT secret; start_validation.sh and
  compose_db_identity_test.sh supply it; docker-compose.test.yml takes
  OS_PASSWORD from the environment instead of a hardcoded 'secret'.
- F4: test/vxlan_multinode_test.sh arms the hatch (both fixture nodes
  boot admin/secret by design).
- F5: 'lightstack migrate' rejects positional arguments — Go's flag
  parsing stops at the first one, so 'migrate up --config X --dry-run'
  silently ran a REAL migration against the DEFAULT config.
- F6: runCleanup's doc comment reattached to runCleanup (it had drifted
  onto loadConfig).
- F7: CONFIGURATION.md env-var table gains LIGHTSTACK_ADMIN_PASSWORD
  and the hatch variable; brittle 'exactly fourteen' count dropped.
- F8: release concurrency queues (cancel-in-progress: false) — a
  cancelled in-flight publish between image and chart push is exactly
  the partial state the pipeline warns about.

Signed-off-by: Uwe Schwaeke <uwe.schwaeke@sap.com>
…stack auth, boot-path docs

- F1: the denylists missed repo-shipped placeholders in boot-path docs —
  docs/SINGLE_NODE_DEPLOYMENT.md and docs/SCALING.md JWT secrets, and the
  admin placeholder this branch itself added to README-KVM (its JWT
  sibling was denylisted, the admin one was not — a user who fixes only
  the JWT after the first refusal would boot with the repo-published
  admin credential). All three added, with test coverage.
- F2: start_validation.sh boots the stack with a generated admin
  password (BootstrapAdmin replaces the seeded admin/secret hash), so
  the validation suite it runs must authenticate with the same password
  — OS_PASSWORD now defaults from LIGHTSTACK_ADMIN_PASSWORD, and the
  printed login lines no longer claim 'secret'.
- F3: the copy-paste boot paths for docker-compose-horizon.yml now
  export both required secrets (README, QUICK_REFERENCE, UNIFIED_,
  HORIZON_SETUP); admin/secret login claims replaced with the actual
  source (the env var or /root/.lightstack-env, which the deploy script
  writes); .env.example gains the LIGHTSTACK_ADMIN_PASSWORD entry; the
  horizon compose SECRET_KEY comment no longer claims every caller
  drives the file without exporting anything.
- F4: scripts/start-lightstack-background.sh boots the canned config
  with no opt-out — dead since the guard. Arms the documented hatch
  (same policy as make run), and documents that 'serve' is an ignored
  positional.

Signed-off-by: Uwe Schwaeke <uwe.schwaeke@sap.com>
…st gaps

- F1: HORIZON_SETUP and QUICK_REFERENCE still carried 'Default
  Credentials: admin/secret' blocks — a credential that can no longer
  log in to the stack their own quick starts boot (the horizon compose
  requires a real LIGHTSTACK_ADMIN_PASSWORD and the guard refuses
  admin/secret). Both blocks now point at the exported password.
- F2: the horizon test scripts (horizon_compat, horizon_dashboard,
  horizon_critical, validation_suite) hardcoded admin/secret with no
  override — they now prefer OS_PASSWORD / LIGHTSTACK_ADMIN_PASSWORD
  (the pattern spec007_admin_bootstrap_test.sh already uses), so they
  keep working against the horizon stack and the hatch-armed dev
  stacks alike. horizon_critical's single-quoted JSON payloads splice
  the variable correctly.
- F3: CONFIGURATION.md claimed 'there is no env override for these'
  400 lines after the same file documented LIGHTSTACK_ADMIN_PASSWORD —
  reworded.
- F4: two more repo-shipped example secrets denylisted
  (dev-secret-do-not-use-in-prod, USE-STRONG-RANDOM-SECRET) with test
  coverage.

Signed-off-by: Uwe Schwaeke <uwe.schwaeke@sap.com>
- UNIFIED_DEPLOYMENT quick-start Step 5 still printed 'Password: secret'
  between two blocks that (since round 3) point at the exported
  LIGHTSTACK_ADMIN_PASSWORD — every user completing the quick start
  failed login at the final step.
- horizon_dashboard_test.sh's success banner still instructed
  admin/secret after round 4 gave the script real-password support —
  now prints the credential it actually tested with.

Signed-off-by: Uwe Schwaeke <uwe.schwaeke@sap.com>
@senolcolak

Copy link
Copy Markdown
Collaborator Author

Review-fix loop on this PR — converged CLEAN ✅

This PR went through a fresh review-fix loop on top of its earlier rounds (the pre-loop history: 0233ca2, b504a33, 5c423ac, 44ab893). Full trend of the new loop:

Round Findings Fixed in
1 3 Medium / 2 Low (+ informational: missing migrate subcommand) 62cc2c4
2 2 High / 5 Medium / 1 Low 302555a
3 3 Medium / 1 Low 04f968d
4 1 Medium / 3 Low 3f5d89b
5 2 Low aa3ea62
6 (final) CLEAN — 0 findings —

Round 1 — the foundation fixes

  • MEDIUMs: the secret guard matched case-sensitively, so the uppercase CHANGE-ME-IN-PRODUCTION shipped in README-KVM.md bypassed it (now case-insensitive + whitespace-trimmed, example generates a per-deployment secret); the release pipeline published the Helm chart with no validation (now runs make chart-test — the same gate CI runs — before helm push, which cannot be undone); the guard ignored the shipped admin_password: secret default.
  • LOWs: cleanup/console-tokens ran the guarded loader (now LoadConfigForCLI, mirroring the migration tool's exemption); guard tests were not hermetic against a developer shell's exported LIGHTSTACK_JWT_SECRET.
  • Informational (fixed): lightstack migrate subcommand — deploy-single-node.sh and upgrade-lightstack.sh have always called it; the positional previously fell through to flag parsing and started the server instead of migrating. --dry-run prints No migrations to run, the exact string the upgrade script greps for.

Round 2 — the significant one

  • HIGH (F1): the round-1 admin guard had an omit-both-fields escape — but migrations/002 seeds an enabled admin/bcrypt(secret) account in every deployment and BootstrapAdmin only warns on an empty password, so omitting the field is precisely how the public credential stays live. The guard now refuses empty/well-known admin_password unconditionally, with a new LIGHTSTACK_ADMIN_PASSWORD env override (mirroring LIGHTSTACK_JWT_SECRET) keeping the bare docker run path workable.
  • HIGH (F2): the CI rgw-integration stack booted the image's canned admin/secret with no opt-out — the new guard crash-looped it (job went red on 62cc2c4). Now arms the documented hatch, matching dev-stack policy.
  • MEDIUMs: the horizon compose requires LIGHTSTACK_ADMIN_PASSWORD (:?) like its JWT secret, with every consumer wired (start_validation.sh, compose_db_identity_test.sh, docker-compose.test.yml); the vxlan test arms the hatch; deploy scripts generate real admin passwords and carry them through the rendered config, CLI env file and summary.
  • LOWs: migrate rejects positionals (Go flag parsing stops at the first one — migrate up --config X --dry-run silently ran a real migration against the default config); runCleanup's doc comment reattached; env-var table completed; release concurrency queues instead of cancels (a cancelled publish between image and chart push is exactly the partial state the pipeline warns about).

Rounds 3–5 — convergence fallout

Denylist gaps for repo-shipped doc placeholders (SINGLE_NODE/SCALING JWT secrets, both paste-output-of-openssl-rand-* admin placeholders, dev-secret-do-not-use-in-prod, USE-STRONG-RANDOM-SECRET) — all with test coverage; start_validation.sh OS_PASSWORD plumbing (the suite authenticates with the generated password BootstrapAdmin installs); the horizon test scripts' credential overrides (incl. correct shell splicing inside single-quoted JSON, verified by executing the pattern); copy-paste boot paths in README/QUICK_REFERENCE/UNIFIED/HORIZON_SETUP export both secrets; last admin/secret credential claims removed from docs and banners.

Round 6 — CLEAN

Final sweep of all 41 changed files, full unit suite (-race, DB-backed) green, every boot path verified wired (hatch or real/generated password).

CI on the final commit: 10/10 checks green (incl. DCO, SAP Sign-off, the previously-failing Ceph RGW job).

…lease path

Review findings (comprehensive review of the open senolcolak PRs):

- MEDIUM: 0.6.x configs have no keystone.admin_password, so script-deployed
  upgrades crash-loop under the new guard with no documented remedy. Add an
  UPGRADING.md section (exact error, both recovery routes, no-clobber
  guarantee), a CHANGELOG breaking-change callout, and an idempotent
  upgrade-script injection that backs up the config and generates a
  URL-safe password.
- MEDIUM: the release workflow never reconciled Chart.yaml version with the
  tag; OCI tags are immutable, so the next release would fail after the
  image push and draft release. Add a pre-flight appVersion check before
  anything is built, and skip (with a warning) an already-published chart
  version.
- MEDIUM: turnkey wrote real admin/JWT/DB secrets into a 0755 dir/0644 file
  and both scripts wrote 0644 env files. Use 0700/0600.
- LOW: three current-state docs still presented admin/secret; scrub them and
  the other docs that implied it.
- LOW: chart validation ran after the irreversible GHCR push and draft
  release; move it before the build, pin Helm 3.22.1 and helm-unittest 1.2.1
  (matching CI), and clear the actionlint warnings.

Signed-off-by: Uwe Schwaeke <uwe.schwaeke@sap.com>
senolcolak pushed a commit that referenced this pull request Nov 2, 2026
…findings

Review findings (comprehensive review of the open senolcolak PRs). These
docs describe the post-#103 merged state, so #103 must merge first:

- HIGH: Path B required only LIGHTSTACK_JWT_SECRET and logged in with
  admin/secret, but #103's horizon compose requires LIGHTSTACK_ADMIN_PASSWORD
  via :? and logs in with it. Require both secrets everywhere, generate them
  with openssl, and update the login instructions. CONFIGURATION's env table
  is now sixteen rows (adds ADMIN_PASSWORD and the dev-only hatch).
- MEDIUM: shipped Horizon local_settings used _member_, a role that does not
  exist; both configs now use member (the seeded role).
- MEDIUM: the documented rollback command no-ops — docker exec without -i
  gives the interactive down prompt EOF and exits 0. Feed yes and use -i.
- MEDIUM: two [Unreleased] sections contradicted each other; fold the legacy
  v2.0 list into a clearly historical block.
- MEDIUM: the contract-test README called a superseded report current; state
  the soft gate/85% floor and date the snapshot.
- LOW: .env belongs beside the compose file, not the repo root; and the
  migration baseline was 059, not 055.

Signed-off-by: Uwe Schwaeke <uwe.schwaeke@sap.com>
Shared CI unblocker for the open PRs (independent of this PR's content):

- govulncheck now reports GO-2026-6809 in crypto/x509 (reachable through
  the HTTP server), fixed in Go 1.27.3. Main pins 1.27.2 everywhere, so
  every PR's Runtime Vulnerabilities and SBOM job fails. Pin 1.27.3 in
  go.mod, tools/go.mod, CI workflows, the builder image, the test
  container and the single-node deploy script (version + sha256).
- The unpinned Helm install now pulls Helm 4, whose 'helm plugin install'
  rejects the helm-unittest source without --verify=false, failing the
  Helm Charts job with 'plugin source does not support verification'.
  Install Helm 3.22.1 and helm-unittest 1.2.1 in an isolated plugin dir,
  matching PR #107, so the gate is version-stable.

Signed-off-by: Uwe Schwaeke <uwe.schwaeke@sap.com>
@senolcolak

Copy link
Copy Markdown
Collaborator Author

Comprehensive review — findings fixed

Reviewed against origin/main @ e909227. The release mechanics verified end-to-end (version stamping round-trips; guard has no bypass for whitespace/case/env-smuggling; migrate interface matches both scripts; chart lint/render clean).

Found 7 (5 Medium, 2 Low) — all fixed in c993431.

Severity Finding Fix
Med 0.6.x configs have no keystone.admin_password; documented upgrades crash-loop under the new guard with no remedy UPGRADING.md section (exact error + both recovery routes + no-clobber guarantee), CHANGELOG breaking-change callout, idempotent upgrade-script injection with backup and URL-safe generated password
Med Chart version never reconciled with the tag; OCI tags are immutable, so the next release fails after the image push and draft release Pre-flight appVersion == IMAGE_TAG check before any build; publish skips an existing chart version with a warning
Med Turnkey wrote real admin/JWT/DB secrets into a 0755 dir / 0644 file; both scripts wrote 0644 env files 0700 config dir, 0600 config and env files
Low Three current-state docs still presented admin/secret Scrubbed, plus six other docs that implied it
Low Chart validation ran after the irreversible GHCR push/draft release; write-privileged job used unpinned Helm Chart install/lint/test moved before build; Helm 3.22.1 + helm-unittest 1.2.1 pinned; actionlint clean

Not fixed (coordination, no renumbering):

CI unblocker included (ed7d5f0): Go 1.27.3 for GO-2026-6809 + pinned Helm (was failing every PR's SBOM/Helm jobs).

CI: 10/10 green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant